Browse Source

RN 5.3 Moved the checkmark on toggle menu items to RHS

pull/1486/head
Tyler Kelly 5 years ago
parent
commit
aeac51a1e8
  1. BIN
      images/53_togglemenuitemchecked.png
  2. BIN
      images/old_togglemenuitemchecked.png
  3. 11
      release-notes/release-notes53.md
  4. 2
      ui-components/menuitems.md

BIN
images/53_togglemenuitemchecked.png

After

Width: 260  |  Height: 130  |  Size: 6.7 KiB

BIN
images/old_togglemenuitemchecked.png

After

Width: 241  |  Height: 130  |  Size: 6.9 KiB

11
release-notes/release-notes53.md

@ -22,6 +22,17 @@ These release notes provide an overview of the changes for {{site.productname}}
The following new features and enhancements were added for the {{site.productname}} 5.3 release.
### Moved the 'enabled' checkmark on toggle menu items to the right-hand side
The checkmark on toggle menu items that indicates that an option is enabled, has been moved. The checkmark will now appear to the right of the menu label. This change provides clearer feedback to users and allows icons to be added to toggle menu items.
For example:
| {{site.productname}} 5.2 toggle menu item checkmark behavior | {{site.productname}} 5.3 toggle menu item checkmark behavior |
| :-----------------------------------------------------------------------------------------------: | :------------------------------------------------------------------------------------------: |
| ![Custom toggle menu item with checkmark on the left-hand side of the item label (pre-5.3 behavior)]({{site.baseurl}}/images/old_togglemenuitemchecked.png) | ![Custom toggle menu item with checkmark on the right-hand side of the item label (5.3+ behavior)]({{site.baseurl}}/images/53_togglemenuitemchecked.png) |
For information on toggle menu items, see: [Custom menu items - Toggle menu items]({{site.baseurl}}/ui-components/menuitems/#togglemenuitems).
###

2
ui-components/menuitems.md

@ -122,7 +122,7 @@ editor.ui.registry.addNestedMenuItem('nesteditem', {
### Toggle menu items
A toggle menu item triggers its `onAction` when clicked. It also has a concept of state. This means it can be toggled `on` and `off`. A toggle menu item gives the user visual feedback for its state through a checkmark that appears to the left of the menu item's text when it is `on`.
A toggle menu item triggers its `onAction` when clicked. It also has a concept of state. This means it can be toggled `on` and `off`. A toggle menu item gives the user visual feedback for its state through a checkmark that appears to the right of the menu item's text when it is `on`.
#### Config options

Loading…
Cancel
Save