Browse Source

DOC-564 fixing the image uploader pages mess

pull/1565/head
Tyler Kelly 5 years ago
parent
commit
aeb994c8e1
  1. 1
      _data/nav.yml
  2. 1
      _includes/configuration/images-dataimg-filter.md
  3. 1
      _includes/configuration/images-upload-base-path.md
  4. 1
      _includes/configuration/images-upload-credentials.md
  5. 26
      _includes/configuration/images-upload-handler.md
  6. 159
      advanced/handle-async-image-uploads.md
  7. 134
      general-configuration-guide/upload-images.md

1
_data/nav.yml

@ -657,7 +657,6 @@
- url: "configuring-comments-callbacks"
- url: "yeoman-generator"
- url: "creating-custom-notifications"
- url: "handle-async-image-uploads"
- url: "php-upload-handler"
- url: "editor-command-identifiers"
pages:

1
_includes/configuration/images-dataimg-filter.md

@ -11,6 +11,7 @@ The **images_dataimg_filter** option is used to filter `<img>` elements before t
```js
tinymce.init({
selector: 'textarea', // change this value according to your HTML
images_upload_url: 'postAcceptor.php',
images_dataimg_filter: function(img) {
return !img.hasAttribute('internal-blob'); // blocks the upload of <img> elements with the attribute "internal-blob".
}

1
_includes/configuration/images-upload-base-path.md

@ -9,6 +9,7 @@ This option lets you specify a `basepath` to prepend to URLs returned from the c
```js
tinymce.init({
selector: 'textarea', // change this value according to your HTML
images_upload_url: 'postAcceptor.php',
images_upload_base_path: '/some/basepath'
});
```

1
_includes/configuration/images-upload-credentials.md

@ -14,6 +14,7 @@ The **images_upload_credentials** option lets you specify if calls to the config
```js
tinymce.init({
selector: 'textarea', // change this value according to your HTML
images_upload_url: 'postAcceptor.php',
images_upload_credentials: true
});
```

26
_includes/configuration/images-upload-handler.md

@ -2,9 +2,16 @@
The **images_upload_handler** option allows you to specify a function that is used to replace {{site.productname}}'s default JavaScript upload handler function with custom logic.
The upload handler function takes four arguments: `blobInfo`, a `success` callback, a `failure` callback, and progress value (between 1 and 100). When this option is not set, {{site.productname}} utilizes an `XMLHttpRequest` to upload images one at a time to the server and calls the success callback with the location of the remote image.
The upload handler function takes four arguments:
>Note: Please note that when using this option, no other image uploader options are necessary. Additionally, if you would like {{site.productname}} to replace the `<image>` tag's `src` attribute with the remote location, please use the success callback defined in the `images_upload_handler` function with the returned JSON object's location property.
* `blobInfo`
* A `success` callback
* A `failure` callback
* A `progress` callback (returning a value between 1 and 100)
When this option is not set, {{site.productname}} utilizes an `XMLHttpRequest` to upload images one at a time to the server and calls the success callback with the location of the remote image.
>Note: To replace the `<img>` tag's `src` attribute with the remote location, please use the success callback defined in the `images_upload_handler` function with the returned JSON object's location property.
**Type:** `JavaScript Function`
@ -13,17 +20,21 @@ The upload handler function takes four arguments: `blobInfo`, a `success` callba
```js
tinymce.init({
selector: 'textarea', // change this value according to your HTML
images_upload_handler: function (blobInfo, success, failure) {
images_upload_handler: function (blobInfo, success, failure, progress) {
var xhr, formData;
xhr = new XMLHttpRequest();
xhr.withCredentials = false;
xhr.open('POST', 'postAcceptor.php');
xhr.upload.onprogress = function(e) {
progress(e.loaded / e.total * 100);
};
xhr.onload = function() {
var json;
if (xhr.status != 200) {
if (xhr.status < 200 || xhr.status >= 300) {
failure('HTTP Error: ' + xhr.status);
return;
}
@ -38,6 +49,10 @@ tinymce.init({
success(json.location);
};
xhr.onerror = function () {
failure('Image upload failed due to a XHR Transport error. Code: ' + xhr.status);
};
formData = new FormData();
formData.append('file', blobInfo.blob(), blobInfo.filename());
@ -45,6 +60,3 @@ tinymce.init({
}
});
```

159
advanced/handle-async-image-uploads.md

@ -1,159 +0,0 @@
---
layout: default
title: Handle asynchronous image uploads
title_nav: Asynchronous image uploading
description_short: How to manage asynchronous image uploads.
description: How to manage asynchronous image uploads with jQuery, CORS.
keywords: asynchronous async paste_data_images image cors
---
{{site.productname}} uploads edited images with the image uploader. This complements {{site.productname}}'s image editing functionality. Local images added through other means can also be uploaded using this functionality. For example, _drag and drop_ using the [paste_data_images]({{ site.baseurl }}/plugins/paste/#paste_data_images) configuration property or using the **PowerPaste** plugin.
{{site.productname}} automatically updates the `<image>` src attribute with the new path to the remote image.
Local images are uploaded to {{site.productname}} using the `editor.uploadImages()` function. This functionality makes it possible for users to save their content *before* all images have completed uploading. No server path to the remote image is available if this occurs and the images will be stored as `Base64`.
> **Note**: Execute the `editor.uploadImages()` function _before_ submitting the editor contents to the server to avoid storing the images as Base64. Use a success callback to execute code once all the images are uploaded. This success callback can save the editor's content to the server through a `POST`.
Review the examples below:
#### Using uploadImages and then posting a form
```js
tinymce.activeEditor.uploadImages(function(success) {
document.forms[0].submit();
});
```
#### Using uploadImages with jQuery
```js
tinymce.activeEditor.uploadImages(function(success) {
$.post('ajax/post.php', tinymce.activeEditor.getContent()).done(function() {
console.log("Uploaded images and posted content as an ajax request.");
});
});
```
## Image Uploader requirements
A server-side upload handler script uploads local images to a remote server. The script must:
* accepts the images on the server
* stores images appropriately
* returns a JSON object containing the image's upload location
An example PHP upload handler implementation is available [here]({{ site.baseurl }}/advanced/php-upload-handler/).
Images are sent to the Image Uploader via HTTP POST with each post containing a single image. The image handler at the URL referenced in the `images_upload_url` must "store" the image in the application. Some examples include:
* Store the item in a folder on the web server
* Store the item on a CDN server
* Store the item in a database
* Store the item in an asset management system
Use a standardized name in the post (e.g. `blobid0`, `blobid1`, `imagetools0`, `imagetools1`) when the image is uploaded.
> **Note**: Ensure that your upload handler script generates a unique name for each uploaded file before storing the image. A common method is to append the current time in milliseconds to the end of the file name. This creates file names such as `blobid0-1458428901092.png` or `blobid0-1460405299-0114.png`.
> **Warning**: The files will be overwritten if the file names are **not** unique.
This server-side upload handler script must return a JSON object containing a "location" property. This property represents the remote location and/or filename of the newly uploaded image.
```
{ location : '/uploaded/image/path/image.png' }
```
## Image Uploader options
The operation of this feature is affected by the following configuration options.
> Note: The `images_upload_url` or `images_upload_handler` options must be set for image uploads to function correctly.
| Image Upload Handling Option | Description |
|----------------------------------|----------------------|
| [images_upload_url]({{ site.baseurl }}/configure/file-image-upload/#images_upload_url) | Specifies a URL where images are uploaded when `editor.uploadImages` is called. |
| [images_upload_base_path]({{ site.baseurl }}/configure/file-image-upload/#images_upload_base_path) | Specifies a basepath to prepend to urls returned from the `configured images_upload_url` page. |
| [images_upload_credentials]({{ site.baseurl }}/configure/file-image-upload/#images_upload_credentials) | Specifies if calls to the configured `images_upload_url` passes along credentials cross domain, like cookies. This is disabled by default. |
| [images_upload_handler]({{ site.baseurl }}/configure/file-image-upload/#images_upload_handler) | This option replaces the [`editor.uploadImages` API method]({{site.baseurl}}/api/tinymce/tinymce.editor/#uploadimages) with custom logic, such as a PHP script. The upload handler function takes three arguments: blobInfo, success callback, and failure callback. When this option is not set, TinyMCE utilizes an `XMLHttpRequest` to upload images one at a time to the server, and calls the success callback with the location of the remote image. |
The following example is a typical setup:
```js
tinymce.init({
selector: 'textarea', // change this value according to your HTML
images_upload_url: 'postAcceptor.php',
images_upload_base_path: '/some/basepath',
images_upload_credentials: true
});
```
## Rolling your image handler
Use the `images_upload_handler` configuration property to change {{site.productname}}'s default image upload logic.
> **Note**: No other image uploader options are necessary while using this option
Use the success callback defined in the image_upload_handler function with the returned JSON object's location property to replace the `<image>` tag's src attribute with the remote location.
The following example is a typical setup:
```js
tinymce.init({
selector: 'textarea', // change this value according to your HTML
images_upload_handler: function (blobInfo, success, failure) {
var xhr, formData;
xhr = new XMLHttpRequest();
xhr.withCredentials = false;
xhr.open('POST', 'postAcceptor.php');
xhr.onload = function() {
var json;
if (xhr.status < 200 || xhr.status >= 300) {
failure('HTTP Error: ' + xhr.status);
return;
}
json = JSON.parse(xhr.responseText);
if (!json || typeof json.location != 'string') {
failure('Invalid JSON: ' + xhr.responseText);
return;
}
success(json.location);
};
formData = new FormData();
formData.append('file', blobInfo.blob(), blobInfo.filename());
xhr.send(formData);
}
});
```
## CORS considerations
Configure [Cross-origin resource sharing (CORS)](http://en.wikipedia.org/wiki/Cross-origin_resource_sharing) to upload image data to a separate domain and to comply with JavaScript "same origin" restrictions.
CORS maintains stringent rules about what constitutes a cross-origin request. The browser can require CORS headers when uploading to the same server the editor is hosted on. For example:
* A different port on the same domain name
* Using the host IP address instead of the domain name
* Swapping between HTTP and HTTPS for the page and the upload script
The upload script URL origin must exactly match the origin of the URL in the address bar, or the browser will require CORS headers to access it. Use a relative URL to specify the script address instead of an absolute one to guarantee this.
All supported browsers print messages to the JavaScript console if there is a CORS error.
The [PHP Upload Handler Script](../php-upload-handler/) provided here configures CORS in the `$accepted_origins` variable. Configure CORS at the [web application layer](http://www.w3.org/wiki/CORS_Enabled#At_the_Web_Application_level...) or the [HTTP server layer](http://www.w3.org/wiki/CORS_Enabled#At_the_HTTP_Server_level...).
### Further reading on CORS
* [W3C Wiki - CORS Enabled](http://www.w3.org/wiki/CORS_Enabled)
* [MDN - HTTP access control (CORS)](https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS)
* [W3C - Cross-Origin Resource Sharing Specification](http://www.w3.org/TR/cors/)
file_picker_callback

134
general-configuration-guide/upload-images.md

@ -1,23 +1,30 @@
---
layout: default
title: Uploading images and files
title_nav: Upload images &amp; files
keywords: uploader uploadImages image handler
title: Handling image uploads
title_nav: Image uploads
description_short: How to manage asynchronous image uploads.
description: How to manage asynchronous image uploads.
keywords: uploader uploadImages image handler asynchronous async paste_data_images image cors
---
The image uploader is designed to complement the image editing functionality of {{site.productname}}. Images that are edited within {{site.productname}} can be uploaded using this function. Local images that are added through other means are also uploaded using this function, such as images added by drag and drop when using the [paste_data_images]({{ site.baseurl }}/plugins/paste/#paste_data_images) configuration property, or using the {{site.companyname}} [PowerPaste plugin]({{ site.baseurl }}/plugins/powerpaste/).
{{site.productname}} uploads edited images with the image uploader. This complements {{site.productname}}'s image editing functionality.
> **Note**: Execute the `editor.uploadImages()` function _before_ submitting the editor contents to the server to avoid storing the images as Base64. Use a success callback to execute code once all the images are uploaded. This success callback can save the editor's content to the server through a `POST`.
Local images can be uploaded to {{site.productname}} through the use of the `editor.uploadImages()` function. This functionality is handled asynchronously, meaning that it is possible for users to save their content before all images have completed uploading. If this occurs and no server path to the remote image is available, the images are saved as Base 64.
Local images that are added through other means are also uploaded using this function, such as images added by drag and drop when using the [`paste_data_images`]({{ site.baseurl }}/plugins/paste/#paste_data_images) configuration property, or using the {{site.companyname}} [**PowerPaste** plugin]({{ site.baseurl }}/plugins/powerpaste/).
{{site.productname}} automatically updates the `<img>` src attribute with the new path to the remote image.
Local images are uploaded to {{site.productname}} using the `editor.uploadImages()` function. This functionality makes it possible for users to save their content *before* all images have completed uploading. If this occurs and no server path to the remote image is available, the images are saved as `Base64`.
> **Note**: Execute the `editor.uploadImages()` function _before_ submitting the editor contents to the server to avoid storing the images as Base64. Use a success callback to execute code once all the images are uploaded. This success callback can save the editor's content to the server through a `POST`.
It is recommended that the `editor.uploadImages()` function be executed before submitting the editor contents to the server, to avoid saving content as Base 64. Once all the images are uploaded, a success callback can be utilized to execute the code. This success callback can be used to save the editor's content to the server through a `POST`.
Review the examples below:
#### Using uploadImages and then posting a form
```js
tinymce.activeEditor.uploadImages(function(success) {
document.forms[0].submit();
document.forms[0].submit();
});
```
@ -26,119 +33,90 @@ tinymce.activeEditor.uploadImages(function(success) {
```js
tinymce.activeEditor.uploadImages(function(success) {
$.post('ajax/post.php', tinymce.activeEditor.getContent()).done(function() {
console.log("Uploaded images and posted content as an ajax request.");
console.log("Uploaded images and posted content as an ajax request.");
});
});
```
## Image uploader requirements
## Image Uploader requirements
A server-side upload handler script that accepts images on the server saves them appropriately and returns a JSON object containing the location of the saved images is necessary to upload local images to a remote server.
A server-side upload handler script uploads local images to a remote server. The script must:
* Accept the images on the server
* Store images appropriately
* Return a JSON object containing the image's upload location
An example PHP upload handler implementation is available [here]({{ site.baseurl }}/advanced/php-upload-handler/).
Images are sent to the Image Uploader via HTTP POST with each post containing a single image. The image handler at the URL referenced in the `images_upload_url` takes care of the process required to "save" the image in your application. Some examples would include:
Images are sent to the Image Uploader via HTTP POST with each post containing a single image. The image handler at the URL referenced in the `images_upload_url` must "store" the image in the application. Some examples include:
* Save the item in a folder on your web server
* Save the item on a CDN server
* Save the item in a database
* Save the item in an asset management system
* Store the item in a folder on the web server
* Store the item on a CDN server
* Store the item in a database
* Store the item in an asset management system
When the image is uploaded it has a standardized name in the post (e.g. `blobid0`, `blobid1`, `imagetools0`, `imagetools1`).
Use a standardized name in the post (e.g. `blobid0`, `blobid1`, `imagetools0`, `imagetools1`) when the image is uploaded.
> **Note**: Ensure that your upload handler script generates a unique name for each uploaded file before storing the image. A common method is to append the current time in milliseconds to the end of the file name. This creates file names such as `blobid0-1458428901092.png` or `blobid0-1460405299-0114.png`.
> **Warning**: The files will be overwritten if the file names are **not** unique.
This server-side upload handler must return a JSON object that contains a `location` property. This property should represent the remote location or filename of the newly uploaded image.
This server-side upload handler script must return a JSON object containing a "location" property. This property represents the remote location and filename of the newly uploaded image.
```
{ location : '/uploaded/image/path/image.png' }
```
## Image uploader options
## Image upload options
There are multiple configuration options that affect the operation of this feature. These options are listed below.
Set the `images_upload_url` _or_ `images_upload_handler` option for image uploads to function. The other options shown here are optional.
> Note: For image uploads to function correctly, either the `images_upload_url` or `images_upload_handler` options must be set.
Required:
| Image Upload Handling Option | Description |
|----------------------------------|----------------------|
| [images_upload_url]({{ site.baseurl }}/configure/file-image-upload/#images_upload_url) | This option lets you specify a URL to where you want images to be uploaded when you call `editor.uploadImages`. |
| [images_upload_base_path]({{ site.baseurl }}/configure/file-image-upload/#images_upload_base_path) | This option lets you specify a basepath to prepend to urls returned from the configured `images_upload_url` page. |
| [images_upload_credentials]({{ site.baseurl }}/configure/file-image-upload/#images_upload_credentials) | This option lets you specify if calls to the configured `images_upload_url` should pass along credentials like cookies etc cross domain. This is disabled by default. |
| [images_upload_handler]({{ site.baseurl }}/configure/file-image-upload/#images_upload_handler) | This option replaces the [`editor.uploadImages` API method]({{site.baseurl}}/api/tinymce/tinymce.editor/#uploadimages) with custom logic, such as a PHP script. The upload handler function takes three arguments: blobInfo, success callback, and failure callback. When this option is not set, TinyMCE utilizes an `XMLHttpRequest` to upload images one at a time to the server, and calls the success callback with the location of the remote image. |
* [`images_upload_url`](#images_upload_url)
##### Example of typical setup
_Or_
```js
tinymce.init({
selector: 'textarea', // change this value according to your html
images_upload_url: 'postAcceptor.php',
images_upload_base_path: '/some/basepath',
images_upload_credentials: true
});
```
* [`images_upload_handler`](#images_upload_handler)
## Rolling your image handler
Optional:
Change the default behavior of {{site.productname}}'s image upload logic by changing the `images_upload_handler` configuration property.
* [`images_upload_base_path`](#images_upload_base_path)
* [`images_upload_credentials`](#images_upload_credentials)
* [`images_reuse_filename`](#images_reuse_filename)
> **Note**: Please note that while using this option, other image uploader options are not necessary. Additionally, to replace the <image> tag's src attribute with the remote location, please use the success callback defined in the `image_upload_handler` function with the returned JSON object's location property.
#{% include configuration/images-uploads-url.md %}
##### Example
#{% include configuration/images-upload-handler.md %}
```js
tinymce.init({
selector: 'textarea', // change this value according to your HTML
images_upload_handler: function (blobInfo, success, failure) {
var xhr, formData;
xhr = new XMLHttpRequest();
xhr.withCredentials = false;
xhr.open('POST', 'postAcceptor.php');
xhr.onload = function() {
var json;
if (xhr.status != 200) {
failure('HTTP Error: ' + xhr.status);
return;
}
json = JSON.parse(xhr.responseText);
if (!json || typeof json.location != 'string') {
failure('Invalid JSON: ' + xhr.responseText);
return;
}
success(json.location);
};
formData = new FormData();
formData.append('file', blobInfo.blob(), blobInfo.filename());
xhr.send(formData);
}
});
```
#{% include configuration/images-upload-base-path.md %}
#{% include configuration/images-upload-credentials.md %}
#{% include configuration/images-upload-reuse-filename.md %}
#{% include configuration/images-dataimg-filter.md %}
## CORS considerations
Configure [Cross-origin resource sharing (CORS)](http://en.wikipedia.org/wiki/Cross-origin_resource_sharing) to allow the web application to upload image data to a separate domain. This ensures compliance with JavaScript *same-origin* restrictions.
Configure [Cross-origin resource sharing (CORS)](http://en.wikipedia.org/wiki/Cross-origin_resource_sharing) to upload image data to a separate domain and to comply with JavaScript "same origin" restrictions.
CORS has stringent rules about what constitutes a cross-origin request. The browser can require CORS headers when uploading to the same server the editor is hosted on, for example:
CORS maintains stringent rules about what constitutes a cross-origin request. The browser can require CORS headers when uploading to the same server the editor is hosted on. For example:
* A different port on the same domain name
* Using the host IP address instead of the domain name
* Swapping between HTTP and HTTPS for the page and the upload script
The upload script URL origin must exactly match the origin of the URL in the address bar, or CORS headers should be provided to the browser to access it. A good way to guarantee this is to use a relative URL to specify the script address, instead of an absolute one.
The upload script URL origin must exactly match the origin of the URL in the address bar, or the browser will require CORS headers to access it. Use a relative URL to specify the script address instead of an absolute one to guarantee this.
All supported browsers print a message to the JavaScript console if there is a CORS error.
All supported browsers print messages to the JavaScript console if there is a CORS error.
The [PHP Upload Handler Script]({{ site.baseurl }}/advanced/php-upload-handler/) provided here configures CORS in the `$accepted_origins` variable. Configure CORS at the [web application layer](http://www.w3.org/wiki/CORS_Enabled#At_the_Web_Application_level...) or the [HTTP server layer](http://www.w3.org/wiki/CORS_Enabled#At_the_HTTP_Server_level...).
The [PHP upload handler script]({{ site.baseurl }}/advanced/php-upload-handler/) provided here configures CORS in the `$accepted_origins` variable. Configure CORS at the [web application layer](http://www.w3.org/wiki/CORS_Enabled#At_the_Web_Application_level...) or the [HTTP server layer](http://www.w3.org/wiki/CORS_Enabled#At_the_HTTP_Server_level...).
### Further reading on CORS
* [W3C Wiki - CORS Enabled](http://www.w3.org/wiki/CORS_Enabled)
* [MDN - HTTP access control (CORS)](https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS)
* [W3C - Cross-Origin Resource Sharing Specification](http://www.w3.org/TR/cors/)
{% assign_page next_page = "/general-configuration-guide/spell-checking/index.html" %}
{% include next-step.html next=next_page %}
* [W3C - Cross-Origin Resource Sharing Specification](https://www.w3.org/wiki/CORS)
file_picker_callback
Loading…
Cancel
Save