Browse Source

CEF Issue Tracker moved to GitHub

- Update some of the internal links

Issue #4430
pull/4446/head
Alex Maitland 2 years ago
parent
commit
3ce76eb191
  1. 2
      CONTRIBUTING.md
  2. 2
      CefSharp.Core.Runtime/CefSettingsBase.h
  3. 2
      CefSharp.Core.Runtime/Internals/CefSharpApp.h
  4. 2
      CefSharp.Core.Runtime/Internals/ClientAdapter.cpp
  5. 8
      CefSharp.Core/CefSettingsBase.cs
  6. 4
      CefSharp.Example/CefExample.cs
  7. 2
      CefSharp.OffScreen/ChromiumWebBrowser.cs
  8. 6
      CefSharp.WinForms/ChromiumWebBrowser.cs
  9. 8
      CefSharp.Wpf/ChromiumWebBrowser.cs
  10. 2
      CefSharp/Internals/PathCheck.cs
  11. 2
      ISSUE_TEMPLATE.md
  12. 2
      README.md

2
CONTRIBUTING.md

@ -32,7 +32,7 @@ It maybe helpful to run the `cefclient` application and compare output with `Cef
cefclient.exe --multi-threaded-message-loop --no-sandbox
```
- **MAKE SURE TO TEST WITH THE COMMAND LINE ARGS LISTED ABOVE**
- If you can reproduce the problem with `cefclient` then you'll need to report the bug on https://bitbucket.org/chromiumembedded/cef/overview there is no point opening an issue here. (Make sure you search before opening an issue)
- If you can reproduce the problem with `cefclient` then you'll need to report the bug on https://github.com/chromiumembedded/cef there is no point opening an issue here. (Make sure you search before opening an issue)
### What should I include when creating an `Issue`?

2
CefSharp.Core.Runtime/CefSettingsBase.h

@ -88,7 +88,7 @@ namespace CefSharp
/// **Experimental**
/// Set to true to enable use of the Chrome runtime in CEF. This feature is
/// considered experimental and is not recommended for most users at this time.
/// See issue https://bitbucket.org/chromiumembedded/cef/issues/2969/support-chrome-windows-with-cef-callbacks for details.
/// See issue https://github.com/chromiumembedded/cef/issues/2969
/// </summary>
property bool ChromeRuntime
{

2
CefSharp.Core.Runtime/Internals/CefSharpApp.h

@ -135,7 +135,7 @@ namespace CefSharp
commandLine->AppendSwitch(StringUtils::ToNative(CefSharpArguments::ExitIfParentProcessClosed));
}
//ChannelId was removed in https://bitbucket.org/chromiumembedded/cef/issues/1912/notreached-in-logchannelidandcookiestores
//ChannelId was removed in https://github.com/chromiumembedded/cef/issues/1912
//We need to know the process Id to establish WCF communication and for monitoring of parent process exit
commandLine->AppendArgument(StringUtils::ToNative(CefSharpArguments::HostProcessIdArgument + "=" + Process::GetCurrentProcess()->Id));

2
CefSharp.Core.Runtime/Internals/ClientAdapter.cpp

@ -416,7 +416,7 @@ namespace CefSharp
bool returnFlag = true;
//NOTE: Only called if tooltip changed otherwise called many times
// also only called when using OSR, https://bitbucket.org/chromiumembedded/cef/issues/783
// also only called when using OSR, https://github.com/chromiumembedded/cef/issues/783
if (hasChanged)
{

8
CefSharp.Core/CefSettingsBase.cs

@ -73,7 +73,7 @@ namespace CefSharp
/// **Experimental**
/// Set to true to enable use of the Chrome runtime in CEF. This feature is
/// considered experimental and is not recommended for most users at this time.
/// See issue https://bitbucket.org/chromiumembedded/cef/issues/2969/support-chrome-windows-with-cef-callbacks for details.
/// See issue https://github.com/chromiumembedded/cef/issues/2969
/// </summary>
public bool ChromeRuntime
{
@ -424,7 +424,7 @@ namespace CefSharp
/// <summary>
/// Set command line argument to enable Print Preview See
/// https://bitbucket.org/chromiumembedded/cef/issues/123/add-support-for-print-preview for details.
/// https://github.com/chromiumembedded/cef/issues/123/add-support-for-print-preview for details.
/// </summary>
public void EnablePrintPreview()
{
@ -442,7 +442,7 @@ namespace CefSharp
{
// Use software rendering and compositing (disable GPU) for increased FPS
// and decreased CPU usage.
// See https://bitbucket.org/chromiumembedded/cef/issues/1257 for details.
// See https://github.com/chromiumembedded/cef/issues/1257 for details.
if (!settings.CefCommandLineArgs.ContainsKey("disable-gpu"))
{
settings.CefCommandLineArgs.Add("disable-gpu");
@ -459,7 +459,7 @@ namespace CefSharp
// creation time via IBrowserSettings.WindowlessFrameRate or changed
// dynamically using IBrowserHost.SetWindowlessFrameRate. In cefclient
// it can be set via the command-line using `--off-screen-frame-rate=XX`.
// See https://bitbucket.org/chromiumembedded/cef/issues/1368 for details.
// See https://github.com/chromiumembedded/cef/issues/1368 for details.
if (!settings.CefCommandLineArgs.ContainsKey("enable-begin-frame-scheduling"))
{
settings.CefCommandLineArgs.Add("enable-begin-frame-scheduling");

4
CefSharp.Example/CefExample.cs

@ -14,7 +14,7 @@ namespace CefSharp.Example
{
public static class CefExample
{
//TODO: Revert after https://bitbucket.org/chromiumembedded/cef/issues/2685/networkservice-custom-scheme-unable-to
//TODO: Revert after https://github.com/chromiumembedded/cef/issues/2685
//has been fixed.
public const string ExampleDomain = "cefsharp.example";
public const string BaseUrl = "https://" + ExampleDomain;
@ -161,7 +161,7 @@ namespace CefSharp.Example
//settings.LogSeverity = LogSeverity.Verbose;
//Experimental setting see https://bitbucket.org/chromiumembedded/cef/issues/2969/support-chrome-windows-with-cef-callbacks
//Experimental setting see https://github.com/chromiumembedded/cef/issues/2969
//for details
//settings.ChromeRuntime = true;

2
CefSharp.OffScreen/ChromiumWebBrowser.cs

@ -580,7 +580,7 @@ namespace CefSharp.OffScreen
throw new ArgumentException($"{nameof(viewport)}.{nameof(viewport.Scale)} must be greater than 0.");
}
//https://bitbucket.org/chromiumembedded/cef/issues/3103/offscreen-capture-screenshot-with-devtools
//https://github.com/chromiumembedded/cef/issues/3103
//CEF OSR mode doesn't set the size internally when CaptureScreenShot is called with a clip param specified, so
//we must manually resize our view if size is greater
var newWidth = viewport.Width + viewport.X;

6
CefSharp.WinForms/ChromiumWebBrowser.cs

@ -137,7 +137,7 @@ namespace CefSharp.WinForms
/// Activates browser upon creation, the default value is false. Prior to version 73
/// the default behaviour was to activate browser on creation (Equivalent of setting this property to true).
/// To restore this behaviour set this value to true immediately after you create the <see cref="ChromiumWebBrowser"/> instance.
/// https://bitbucket.org/chromiumembedded/cef/issues/1856/branch-2526-cef-activates-browser-window
/// https://github.com/chromiumembedded/cef/issues/1856
/// </summary>
public bool ActivateBrowserOnCreation { get; set; }
/// <summary>
@ -662,7 +662,7 @@ namespace CefSharp.WinForms
if (!ActivateBrowserOnCreation)
{
//Disable Window activation by default
//https://bitbucket.org/chromiumembedded/cef/issues/1856/branch-2526-cef-activates-browser-window
//https://github.com/chromiumembedded/cef/issues/1856/branch-2526-cef-activates-browser-window
windowInfo.ExStyle |= WS_EX_NOACTIVATE;
}
@ -722,7 +722,7 @@ namespace CefSharp.WinForms
// It's possible to use Cef.PostAction to invoke directly on the CEF UI Thread,
// this also seems to work as expected, using the WinForms UI Thread allows
// us to check the Focused property to determine if we actully have focus
// https://bitbucket.org/chromiumembedded/cef/issues/3436/chromium-based-browser-loses-focus-when
// https://github.com/chromiumembedded/cef/issues/3436/chromium-based-browser-loses-focus-when
if (InvokeRequired)
{
BeginInvoke((Action)(() =>

8
CefSharp.Wpf/ChromiumWebBrowser.cs

@ -140,7 +140,7 @@ namespace CefSharp.Wpf
/// </summary>
private static bool DesignMode;
// https://bitbucket.org/chromiumembedded/cef/issues/3427/osr-rendering-bug-when-minimizing-and
// https://github.com/chromiumembedded/cef/issues/3427
private bool resizeHackIgnoreOnPaint;
private Structs.Size? resizeHackSize;
@ -153,7 +153,7 @@ namespace CefSharp.Wpf
/// <summary>
/// When enabled the browser will resize by 1px when it becomes visible to workaround
/// the upstream issue
/// Hack to work around upstream issue https://bitbucket.org/chromiumembedded/cef/issues/3427/osr-rendering-bug-when-minimizing-and
/// Hack to work around upstream issue https://github.com/chromiumembedded/cef/issues/3427
/// Disabled by default
/// </summary>
public bool ResizeHackEnabled { get; set; } = false;
@ -162,7 +162,7 @@ namespace CefSharp.Wpf
/// Number of milliseconds to wait after resizing the browser when it first
/// becomes visible. After the delay the browser will revert to it's
/// original size.
/// Hack to workaround upstream issue https://bitbucket.org/chromiumembedded/cef/issues/3427/osr-rendering-bug-when-minimizing-and
/// Hack to workaround upstream issue https://github.com/chromiumembedded/cef/issues/3427
/// </summary>
public int ResizeHackDelayInMs { get; set; } = 50;
@ -2793,7 +2793,7 @@ namespace CefSharp.Wpf
}
/// <summary>
/// Resize hack for https://bitbucket.org/chromiumembedded/cef/issues/3427/osr-rendering-bug-when-minimizing-and
/// Resize hack for https://github.com/chromiumembedded/cef/issues/3427/osr-rendering-bug-when-minimizing-and
/// </summary>
/// <returns>Task</returns>
private async Task ResizeHackRun()

2
CefSharp/Internals/PathCheck.cs

@ -50,7 +50,7 @@ namespace CefSharp.Internals
/// <summary>
/// Throw exception if the path provided is non-asbolute
/// CEF now explicitly requires absolute paths
/// https://bitbucket.org/chromiumembedded/cef/issues/2916/not-persisting-in-local-stoage-when-using
/// https://github.com/chromiumembedded/cef/issues/2916
/// Empty paths are ignored
/// </summary>
/// <param name="path">path</param>

2
ISSUE_TEMPLATE.md

@ -49,5 +49,5 @@ e.g. 57.0.0 or 63.0.0-pre01
- To compare with WPF run cefclient --multi-threaded-message-loop --off-screen-rendering-enabled --enable-gpu
- To compare with WinForms run cefclient --multi-threaded-message-loop
- If you can reproduce the problem with `cefclient` then you'll need to report the bug on https://bitbucket.org/chromiumembedded/cef/overview there is no point opening an issue here. (Make sure you search before opening an issue)
- If you can reproduce the problem with `cefclient` then you'll need to report the bug on https://github.com/chromiumembedded/cef there is no point opening an issue here. (Make sure you search before opening an issue)
- Please include the version you tested with e.g. `cef_binary_3.3029.1611.g44e39a8_windows64_client.tar.bz2`. It's important to you test with the same version that `CefSharp` is based on. Check the release notes to determine the version (https://github.com/cefsharp/CefSharp/releases) or load `chrome://version` in the browser.

2
README.md

@ -154,7 +154,7 @@ As a stay at home dad I ([@amaitland](https://github.com/amaitland)) rely on you
## Links
- [CefGlue](https://gitlab.com/xiliumhq/chromiumembedded/cefglue): An alternative .NET CEF wrapper built using P/Invoke.
- [CEF Bitbucket Project](https://bitbucket.org/chromiumembedded/cef/overview) : The official CEF issue tracker
- [CEF GitHub Project](https://github.com/chromiumembedded/cef) : The official CEF issue tracker
- [CEF Forum](http://magpcss.org/ceforum/) : The official CEF Forum
- [CEF API Docs](http://magpcss.org/ceforum/apidocs3/index-all.html) : Well worth a read if you are implementing a new feature
- [CefSharp API Doc](http://cefsharp.github.io/api/)

Loading…
Cancel
Save