Kitware-CMake

41408 Commits

2 Branches

370 Tags

216 MiB

Tree: 8b3a537c29

Commit Graph

Author	SHA1	Message	Date
David Benjamin	cb694f8cd6	VS: Properly quote arguments in nasm.xml Most arguments were quoted, but some weren't, causing problems if the arguments contained whitespace. In particular, the _STL_EXTRA_DISABLED_WARNINGS value takes spaces and CMake's NASM support applies all add_definitions lines to NASM. The -D flag is missing quotes, so projects using NASM and setting _STL_EXTRA_DISABLED_WARNINGS break in the Visual Studio generator. Likewise, the -o flag is missing quotes, which means filenames with spaces do not work. (The -U flag is unlikely to need quotes, but include them for consistency.) Extend the existing VSNASM test to cover these cases.	7 years ago
Evgeny Fimochkin	5ba2c9e5e0	VS: Add support for ASM_NASM language Fixes: #16469	9 years ago

Author

SHA1

Message

Date

David Benjamin

cb694f8cd6

VS: Properly quote arguments in nasm.xml

Most arguments were quoted, but some weren't, causing problems if the
arguments contained whitespace.

In particular, the _STL_EXTRA_DISABLED_WARNINGS value takes spaces and
CMake's NASM support applies all add_definitions lines to NASM. The -D
flag is missing quotes, so projects using NASM and setting
_STL_EXTRA_DISABLED_WARNINGS break in the Visual Studio generator.

Likewise, the -o flag is missing quotes, which means filenames with
spaces do not work.

(The -U flag is unlikely to need quotes, but include them for
consistency.)

Extend the existing VSNASM test to cover these cases.

7 years ago

Evgeny Fimochkin

5ba2c9e5e0

VS: Add support for ASM_NASM language

Fixes: #16469

9 years ago

2 Commits (8b3a537c29974da62f4a46f4631bbec1550a2a23)