a8218b1eeb
Fix bug where some messages could get malformed in an import from a MBOX file ( #9510 )
1 year ago
f4272804d6
Rename test files for PHPUnit 10+ ( #9477 )
1 year ago
6a5f9ee7ce
Add override method attributes ( #9272 )
1 year ago
736795326c
Fix plugins composer.json format ( #9405 )
* Check plugins composer.json using CI
* Add "require-dev" and "config.allow-plugins" to plugins
* fix composer.json format - rm invalid email
* fix composer.json format - fix ext require
* fix composer.json format - fix plugin name
* tmp
* Revert "tmp"
* fix ext in ext install
* disable plugin in plugin install until Roundcube is fully autoloadable
* fix composer.json format - fix non-canonical license name
* Revert "Add "require-dev" and "config.allow-plugins" to plugins"
* no composer install for plugins needed
* Revert "fix ext in ext install"
* add standard "Test" suffix to phpunit files
* rm unneeded "suffix" in phpunit config
* simplify phpunit config
* fix default "xhtml" doctype in unit testing
* fix test_format_date test to not rely on other tests
* even more phpunit config simplify
* stricter/unify phpunit params for E2E tests
* run E2E tests on maximal php version too with lowest deps
* "repositories" in bundled plugins are useless as for root package only
* add/unify missing plugin test
1 year ago
3a76c9b3b6
Code improvements
1 year ago
d18406a8bd
Fix binary operator spaces CS ( #9330 )
* align_single_space_minimal for assign
* assign operators grouping is not supported by PHP CS Fixer
* binary_operator_spaces = single_space
* fix anonymous function on single line
* align comments manually
2 years ago
1f6a9b8843
Fix phpstan errors regarding rcube_uploads trait methods
2 years ago
d976801918
Fix phpstan errors regarding a mocked storage use
2 years ago
4ee79b9e84
fix "explicit_string_variable" ( #9315 )
2 years ago
54f4aa33f9
Fix CS - imports ( #9316 )
* fix Tests\Browser\TestCase imports
* fix remaining imports
* fix PHPUnit\Framework\TestCase imports
* import GuzzleHttp\Client
* fix remaining
* "php_unit_method_casing" is not todo
* fix "single_line_comment_spacing"
* fix 2nd commit done using older fixer
2 years ago
b1a0067e5d
Fix more CS ( #9303 )
* fix "class_attributes_separation"
* fix "ternary_to_null_coalescing"
* fix "no_extra_blank_lines"
* fix "php_unit_data_provider_name" - use snake_case
* fix remaining "function data_" manually
* move "php_unit_test_case_static_method_calls" to a better place in cnf
* fix 3.47.1 CS
2 years ago
6a53a1d853
Fix CS (whitespace, visibility) ( #9297 )
* Fix "method_argument_space"
* Fix "control_structure_continuation_position"
* Fix "new_with_parentheses"
* Fix "blank_line_before_statement"
* Fix "visibility_required"
* Fix some "array_indentation"
* Fix some "array_indentation" - unify all "rcube::raise_error" calls
* rm useless eslint ignores and add rules counts
* sort eslint ignores
* fix eslint ignores grammar
* Revert "Fix "blank_line_before_statement""
* fix CS 3.46.0
2 years ago
2643be3eaa
Fix single quotes CS ( #9283 )
* Fix "single_quote"
* fix "escape_implicit_backslashes"
* fix typo from f363481c
2 years ago
3e458fa5fd
Refer native constants unambiguously ( #9275 )
* Fix "native_constant_invocation" CS
* "self_accessor" was fixed in 9269 PR
* "php_unit_strict" was fixed in 9268 PR
2 years ago
a9167a0d2f
Fix "static_lambda" CS ( #9276 )
2 years ago
97c618122d
Ignore unlink() warning
2 years ago
e7d7e62146
Modernize more basic CS II ( #9254 )
* fix "integer_literal_case"
* fix "phpdoc_separation"
* fix "phpdoc_var_without_name"
* fix "operator_linebreak"
* fix "no_alias_language_construct_call"
* fix "list_syntax"
* fix "concat_space"
* fix "array_syntax"
* fix "binary_operator_spaces"
* fix "binary_operator_spaces" relaxed
* fix "phpdoc_types_order"
* fix "phpdoc_trim"
* fix "native_type_declaration_casing"
* fix "method_chaining_indentation"
* fix "phpdoc_no_package"
* fix "elseif"
* fix PHP CS Fixer config itself too
* fix "native_type_declaration_casing"
2 years ago
ca8b17d191
Modernize more basic CS ( #9258 )
* fix "yoda_style"
* fix "is_null"
* rm useless rule ignores
* add full "PhpCsFixer:risky" ruleset
* fix "implode_call"
* fix "no_alias_functions"
* fix "array_push"
* fix "long_to_shorthand_operator"
* fix "ternary_to_elvis_operator"
* fix "logical_operators"
* fix "fopen_flags"
* rename "returns" phpdoc tags to "return"
* fix "php_unit_construct"
* fix "function_to_constant"
* fix "php_unit_data_provider_return_type"
* fix "php_unit_set_up_tear_down_visibility"
* some safe "string_length_to_empty"
* fix "phpdoc_align"
* fix "phpdoc_no_alias_tag"
* fix "trailing_comma_in_multiline"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl>
2 years ago
a8707ae220
Fix and assert basic CS using CI ( #9246 )
* Assert CS using CI
* fix "single_blank_line_at_eof"
* fix "statement_indentation"
* fix "switch_case_semicolon_to_colon"
* fix "control_structure_braces"
* fix "statement_indentation"
* fix "no_whitespace_in_blank_line"
* fix "no_trailing_whitespace_in_comment"
* fix "no_trailing_whitespace"
* fix "single_space_around_construct"
* fix "spaces_inside_parentheses"
* fix "ternary_operator_spaces"
* fix "trim_array_spaces"
* fix "whitespace_after_comma_in_array"
* fix "cast_spaces"
* fix "unary_operator_spaces"
* fix "no_trailing_comma_in_singleline"
* fix "ordered_imports"
* fix "no_unused_imports"
* Check composer.json format
* fix CI job name
* file header comments are not phpdoc
* fix "phpdoc_indent"
* fix "braces_position"
* fix "phpdoc_types"
* fix "no_blank_lines_after_class_opening"
* fix "no_multiple_statements_per_line"
* fix "multiline_comment_opening_closing"
* fix "single_line_empty_body"
* fix "non_printable_character"
* fix "phpdoc_trim_consecutive_blank_line_separation"
* fix "include"
* fix "no_mixed_echo_print"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl>
2 years ago
600bbf608e
Run unit tests in CI on Windows too ( #9251 )
* Run unit tests in CI on Windows too
* Install::test_check_mime_extensions() has no mime.types on Windows
* Fix sqlite test DB path and unlink for Windows
* Fix rcube::exec() testing for Windows
* Prevent git EOL conversion for tests/
* Fix test_rtf2text test for text with CRLF
* run E2E tests on one php version only
2 years ago
80404a8674
Store uploads metadata in a separate sql database table instead of a session ( #8415 )
3 years ago
44b3ef6671
Small code improvement
3 years ago
71d151dba9
Add some tests and fix flaky test
3 years ago
28b6351750
Fix compatibility with Referrer-Policy: "strict-origin" ( #8170 )
4 years ago
89e54718ca
Migration to PHPUnit v9
4 years ago
6a12cb7b67
Remove browser compatibility check
Improved code style, localized some more errors.
Added tests for utils/error action
5 years ago
7c53300990
PHP8 fixes, CS fixes, short array syntax, tests
5 years ago
1007b873f0
More action tests, PHP8 fixes
5 years ago
836adabbda
Add more actions tests
5 years ago
e99fb3968d
Add tests for contacts export action, fix PHP8 issues
5 years ago
e2572b8984
PHP8 compat. fixes, added some tests
5 years ago
545a1569f1
Steps -> Actions refactoring ( #7688 )
* Move action handling code to rcmail class
* Add rcmail_action class
* Add action aliases
* Get rid of $OUTPUT global
* Move some methods from rcmail to rcmail_action
* PHP8 compat. fixes
* Add framework for testing actions
* Fix obvious code mistakes
5 years ago
Aleksander Machniak