ed0f9b5f67
Fix typo
1 year ago
62ba39123c
Add missing #[\Override] attribute
1 year ago
6a5f9ee7ce
Add override method attributes ( #9272 )
1 year ago
aae7267883
CS fixes
1 year ago
6d8dd2c9a2
Fix fatal error when parsing some TNEF attachments ( #9462 )
1 year ago
ba252dc5e2
Fix cross-site scripting (XSS) vulnerability in handling SVG animate attributes
Reported by Valentin T. and Lutz Wolf of CrowdStrike.
1 year ago
6c54254a2f
Fix folders hierarchy when special folders are subfolders of INBOX, with no personal namespace prefix ( #9452 )
1 year ago
15659d7815
PHPCS: phpdoc_annotation_without_dot=true (default)
1 year ago
1e360999b2
Use composer autoloader for bundled plugins testing ( #9412 )
* use fixed "roundcube/plugin-installer"
* Use composer autoloader for plugins testing
* cherrypick remaining from 9241 related with testing
* minor legacy autoload improvements
1 year ago
4611b55072
Add phpunit slow detector ( #9320 )
1 year ago
52d8172b0f
Allow composer autoloading (to coexist) ( #9407 )
* Replace custom loader in favor of composer native
* Load plugins using composer
* finish debug_logger plugin
* finish markasjunk plugin
* finish password plugin
* finish enigma plugin
* finish managesieve plugin
* fix ExtensionInstaller run on first install
* fix phpstan "Implicit array creation" in plugin config files
* simplify composer.json
* keep non-composer autoloading relying on include_path set in plugins
* update minimal "roundcube/plugin-installer" version
* "plugins.roundcube.net" root-only package repo is not needed
* REVERT ALL
* fix phpstan "Implicit array creation" in plugin config files
* update minimal "roundcube/plugin-installer" version
* reland composer.json changes
* fix ExtensionInstaller run on first install
* Roundcube (non plugin) tests are fine to rely on composer autoload
* fix CS of master
* not needed until strict composer autoloading
* improve comment
* revert rcmail_oauth change - fixed in plugin installer
* require fixed plugin installer
1 year ago
e086c2c97c
Code improvements
1 year ago
736795326c
Fix plugins composer.json format ( #9405 )
* Check plugins composer.json using CI
* Add "require-dev" and "config.allow-plugins" to plugins
* fix composer.json format - rm invalid email
* fix composer.json format - fix ext require
* fix composer.json format - fix plugin name
* tmp
* Revert "tmp"
* fix ext in ext install
* disable plugin in plugin install until Roundcube is fully autoloadable
* fix composer.json format - fix non-canonical license name
* Revert "Add "require-dev" and "config.allow-plugins" to plugins"
* no composer install for plugins needed
* Revert "fix ext in ext install"
* add standard "Test" suffix to phpunit files
* rm unneeded "suffix" in phpunit config
* simplify phpunit config
* fix default "xhtml" doctype in unit testing
* fix test_format_date test to not rely on other tests
* even more phpunit config simplify
* stricter/unify phpunit params for E2E tests
* run E2E tests on maximal php version too with lowest deps
* "repositories" in bundled plugins are useless as for root package only
* add/unify missing plugin test
1 year ago
ec4e4a0028
Fix tests
1 year ago
58d28297a3
Code improvements, PHPDoc fixes
1 year ago
3a76c9b3b6
Code improvements
1 year ago
7b127faec5
Code improvements
1 year ago
3b159a1c25
Code improvements in the spellchecker classes
1 year ago
4e7d5c601e
Code improvements
1 year ago
5ed3b29a0a
Code improvements
1 year ago
02e49ed236
Fix phpstan errors
1 year ago
3dbbbd4ce1
Fix attachment name decoding when 'charset' parameter exists in the headers ( #9376 )
1 year ago
332c165d28
Fix some basic JS CS ( #9328 )
* fix "nonblock-statement-body-position" (fixed already)
* fix "comma-dangle"
* fix "no-regex-spaces"
* fix "new-parens"
* fix "object-curly-newline"
* fix "object-property-newline"
* fix "spaced-comment" semimanually
* fix "no-constant-condition" manually
* fix "unicorn/no-hex-escape"
* fix "unicorn/escape-case"
* fix "quote-props"
* fix "no-whitespace-before-property" - fix bug/typo
* fix "unicorn/empty-brace-spaces"
* fix "keyword-spacing"
* fix "dot-notation"
* fix "no-return-assign" manually
* fix "padding-line-between-statements"
* fix "key-spacing"
* fix "no-else-return" semimanually
* fix some "no-undef"
* fix case cs
* Revert "fix "padding-line-between-statements""
* improve switch/case format I.
* improve switch/case format II.
regex: (^ *(break|return).*)\n *(\n)
* fix safe "eqeqeq"
* fix "radix"
* fix v3.49.0 CS (static providers)
* fix "string_implicit_backslashes" in php files
* fix comments align
* fix test static providers
* fix stan
* disable "final_internal_class" rule
1 year ago
d18406a8bd
Fix binary operator spaces CS ( #9330 )
* align_single_space_minimal for assign
* assign operators grouping is not supported by PHP CS Fixer
* binary_operator_spaces = single_space
* fix anonymous function on single line
* align comments manually
2 years ago
1f6a9b8843
Fix phpstan errors regarding rcube_uploads trait methods
2 years ago
343561b597
Fix regression in the browser tests
2 years ago
c63ec982b2
Fix PHPStan errors in tests/Browser/
2 years ago
dfb88b50c1
Fix bug where HTML entities in URLs were not decoded on HTML to plain text conversion ( #9312 )
2 years ago
d976801918
Fix phpstan errors regarding a mocked storage use
2 years ago
4ee79b9e84
fix "explicit_string_variable" ( #9315 )
2 years ago
54f4aa33f9
Fix CS - imports ( #9316 )
* fix Tests\Browser\TestCase imports
* fix remaining imports
* fix PHPUnit\Framework\TestCase imports
* import GuzzleHttp\Client
* fix remaining
* "php_unit_method_casing" is not todo
* fix "single_line_comment_spacing"
* fix 2nd commit done using older fixer
2 years ago
b1a0067e5d
Fix more CS ( #9303 )
* fix "class_attributes_separation"
* fix "ternary_to_null_coalescing"
* fix "no_extra_blank_lines"
* fix "php_unit_data_provider_name" - use snake_case
* fix remaining "function data_" manually
* move "php_unit_test_case_static_method_calls" to a better place in cnf
* fix 3.47.1 CS
2 years ago
77aca18bd5
Refactorize request_access_token() returning a simple boolean ( #9299 )
2 years ago
a797873ef5
Fix "phpdoc_no_empty_return" CS ( #9302 )
* replace void with never return type
* replace "return void" phpdoc with native type in tests
* replace "return void" phpdoc with native type in rcube_addressbook
* replace "return void" phpdoc with native type in rcmail_oauth
* fix remaining
2 years ago
6a53a1d853
Fix CS (whitespace, visibility) ( #9297 )
* Fix "method_argument_space"
* Fix "control_structure_continuation_position"
* Fix "new_with_parentheses"
* Fix "blank_line_before_statement"
* Fix "visibility_required"
* Fix some "array_indentation"
* Fix some "array_indentation" - unify all "rcube::raise_error" calls
* rm useless eslint ignores and add rules counts
* sort eslint ignores
* fix eslint ignores grammar
* Revert "Fix "blank_line_before_statement""
* fix CS 3.46.0
2 years ago
7a07ce57f5
Test but do not output (while testing) some OAuth errors
2 years ago
2643be3eaa
Fix single quotes CS ( #9283 )
* Fix "single_quote"
* fix "escape_implicit_backslashes"
* fix typo from f363481c
2 years ago
ffa298d41c
OAuth: feat: use OIDC claims on user creation ( #9286 )
Signed-off-by: Edouard Vanbelle <edouard@vanbelle.fr>
2 years ago
14f092c7af
OAuth: security: add support of nonce ( #9288 )
Signed-off-by: Edouard Vanbelle <edouard@vanbelle.fr>
2 years ago
0e4c35797d
core: correct coding style warning ( #9284 )
Signed-off-by: Edouard Vanbelle <edouard@vanbelle.fr>
2 years ago
3e458fa5fd
Refer native constants unambiguously ( #9275 )
* Fix "native_constant_invocation" CS
* "self_accessor" was fixed in 9269 PR
* "php_unit_strict" was fixed in 9268 PR
2 years ago
a9167a0d2f
Fix "static_lambda" CS ( #9276 )
2 years ago
97c618122d
Ignore unlink() warning
2 years ago
9f5cc3e9fa
Accept null as input to parse_bytes()
2 years ago
aa3803eaee
Return `integer|false` from parse_bytes() function ( #9271 )
* Return integer from parse_bytes() function
* fix rebase
* Return false from parse_bytes() function if input is invalid
* allow null until strongly typed
2 years ago
28c778b7a0
Modernize more CS III ( #9270 )
* fix "single_trait_insert_per_statement"
* fix "empty_loop_condition"
* fix "backtick_to_shell_exec"
* fix "phpdoc_to_comment"
* fix "no_empty_statement"
* fix "heredoc_to_nowdoc"
* fix "class_reference_name_casing"
* fix "align_multiline_comment"
* fix "heredoc_indentation"
* fix "constant_case"
* fix "single_line_comment_style"
* fix "no_null_property_initialization"
* fix "standardize_increment"
* fix "no_unneeded_control_parentheses"
* fix missing NL after "<?php"
* fix php in *.sh files too
* fix trailing spaces from all text files
* fix "explicit_indirect_variable"
* Revert "fix "align_multiline_comment""
This reverts commit 42e584f8e32101c2a3a3
2 years ago
7154acf9c5
Tests: convertDeprecationsToExceptions="true"
2 years ago
8c82b29baf
Assert expected data types in tests ( #9268 )
* fix test skips for local testing
* fix Actions_Mail_Search tests when run /w non-UTC default TZ
* improve tests before PHP CS Fixer is run
* fix "php_unit_strict"
2 years ago
9729ff9418
Fix warning on parse_bytes(null) call
2 years ago
2546d2e2e7
Tests: Use mocked Guzzle client in Modcss action test
2 years ago
Aleksander Machniak