From bc7925ff4b4cfdabdda657e28aa63e2faae20725 Mon Sep 17 00:00:00 2001
From: Paul Medynski <31868385+paulmedynski@users.noreply.github.com>
Date: Wed, 23 Jul 2025 10:37:42 -0300
Subject: [PATCH] Remove BuildTests target (#3498)
* Issue #3147 - Can't build SqlClient package
- Fixed case-sensitive filenames.
- Fixed bad dotnet command when generating NotSupported API.
* Issue #3147 - Can't build SqlClient package
- Removed 'BuildTests' target from build.proj.
- Corrected BUILDGUIDE related to building and running tests.
* Discussion #3147 - Can't build SqlClient package
- Removed unused and outdated scripts.
---
BUILDGUIDE.md | 36 +++++-----
RunPackageReferenceTests.cmd | 65 -------------------
RunProjectReferenceTests.cmd | 54 ---------------
RunTests.sh | 8 ---
build.proj | 5 +-
buildAddons.cmd | 12 ----
override.ps1 | 43 ------------
...tory.Build.Props => Directory.Build.props} | 0
tools/targets/NotSupported.targets | 2 +-
9 files changed, 19 insertions(+), 206 deletions(-)
delete mode 100644 RunPackageReferenceTests.cmd
delete mode 100644 RunProjectReferenceTests.cmd
delete mode 100644 RunTests.sh
delete mode 100644 buildAddons.cmd
delete mode 100644 override.ps1
rename tools/GenAPI/{Directory.Build.Props => Directory.Build.props} (100%)
diff --git a/BUILDGUIDE.md b/BUILDGUIDE.md
index aa334124b..efeb747ca 100644
--- a/BUILDGUIDE.md
+++ b/BUILDGUIDE.md
@@ -22,12 +22,12 @@ Once the environment is setup properly, execute the desired set of commands belo
|`BuildNetCore`|Builds the .NET driver for all target frameworks.|
|`BuildNetCoreAllOS`|Builds the .NET driver for all target frameworks and operating systems.|
|`BuildNetFx`|Builds the .NET Framework driver for all target frameworks.|
-|`BuildTests`|Builds tests for the .NET and .NET Framework drivers.|
|`BuildTestsNetCore`|Builds tests for the .NET driver.|
|`BuildTestsNetFx`|Builds tests for the .NET Framework driver.|
|`Clean`|Cleans generated files.|
|`Restore`|Restores Nuget packages.|
-|`RunTests`|Runs the functional and manual tests for the .NET Framework and .NET drivers|
+|`RunTests`|Runs the unit, functional, and manual tests for the .NET Framework and .NET drivers|
+|`RunUnitTests`|Runs just the unit tests for the .NET Framework and .NET drivers|
|`RunFunctionalTests`|Runs just the functional tests for the .NET Framework and .NET drivers|
|`RunManualTests`|Runs just the manual tests for the .NET Framework and .NET drivers|
|`BuildAkv`|Builds the Azure Key Vault Provider package for all supported platforms.|
@@ -51,39 +51,35 @@ Using the default configuration and running all tests:
```bash
msbuild
-msbuild -t:BuildTests
+msbuild -t:BuildTestsNetFx -p:TF=net462
+msbuild -t:BuildTestsNetCore
msbuild -t:RunTests
```
-Targeting .NET Framework (or any specific supported version):
-
-```bash
-msbuild -p:TF=net462
-msbuild -t:BuildTests -p:TF=net462
-msbuild -t:RunTests -p:TF=net462
-```
-
Using the Release configuration:
```bash
msbuild -p:configuration=Release
-msbuild -t:BuildTests -p:configuration=Release
+msbuild -t:BuildTestsNetFx -p:TF=net462 -p:configuration=Release
+msbuild -t:BuildTestsNetCore -p:configuration=Release
msbuild -t:RunTests -p:configuration=Release
```
-Running only the functional tests:
+Running only the unit tests:
```bash
msbuild
-msbuild -t:BuildTests
-msbuild -t:RunFunctionalTests
+msbuild -t:BuildTestsNetFx -p:TF=net462
+msbuild -t:BuildTestsNetCore
+msbuild -t:RunUnitTests
```
Using a specific dotnet version/architecture:
```bash
msbuild -p:configuration=Release
-msbuild -t:BuildTests -p:configuration=Release
+msbuild -t:BuildTestsNetFx -p:TF=net462 -p:configuration=Release
+msbuild -t:BuildTestsNetCore -p:configuration=Release
msbuild -t:RunTests -p:configuration=Release -p:DotnetPath=C:\net8-win-x86\
```
@@ -224,10 +220,10 @@ msbuild -t:BuildTestsNetCore -p:ReferenceType=Package
For .NET Framework, below reference types are supported:
```bash
-msbuild -t:BuildTestsNetFx -p:ReferenceType=Project
+msbuild -t:BuildTestsNetFx -p:TF=net462 -p:ReferenceType=Project
# Default setting uses Project Reference.
-msbuild -t:BuildTestsNetFx -p:ReferenceType=Package
+msbuild -t:BuildTestsNetFx -p:TF=net462 -p:ReferenceType=Package
```
### Running Tests with Reference Type
@@ -245,12 +241,12 @@ Tests can be built and run with custom Target Frameworks. See the below examples
### Building Tests with custom target framework
```bash
-msbuild -t:BuildTestsNetFx -p:TargetNetFxVersion=net462
+msbuild -t:BuildTestsNetFx -p:TF=net462
# Build the tests for custom .NET Framework target
```
```bash
-msbuild -t:BuildTestsNetCore -p:TargetNetCoreVersion=net8.0
+msbuild -t:BuildTestsNetCore -p:TF=net8.0
# Build the tests for custom .NET target
```
diff --git a/RunPackageReferenceTests.cmd b/RunPackageReferenceTests.cmd
deleted file mode 100644
index 4813c182c..000000000
--- a/RunPackageReferenceTests.cmd
+++ /dev/null
@@ -1,65 +0,0 @@
-@echo off
-
-:: .NET CORE TEST CASES
-echo Building .NET Core Tests
-call :pauseOnError msbuild -t:Clean
-
-:: ************** IMPORTANT NOTE BEFORE PROCEEDING WITH "PACKAGE" REFERENCE TYPE ***************
-:: THESE ARE NOT STAND ALONE TEST COMMANDS AND NEED A DEVELOPER'S SPECIAL ATTENTION TO WORK. ATTEMPTING TO RUN THE ENTIRE SET OF COMMANDS AS-IS IS LIKELY TO FAIL!
-
-:: CREATE A NUGET PACKAGE WITH BELOW COMMAND AND ADD TO LOCAL FOLDER + UPDATE NUGET CONFIG FILE TO READ FROM THAT LOCATION
-:: > MSBuild -p:Configuration=Release
-
-:: Based on `dotnet test` documentation, the `Platform` property has no effect on choosing the underlying architecture for the test execution environment.
-:: You need to install and run the `dotnet` command for a specific architecture (x64, x86, Arm64).
-
-:: REFERENCE TYPE "PACKAGE"
-call :pauseOnError msbuild -p:Configuration="Release" -t:BuildAKVNetFx -p:ReferenceType=Package
-call :pauseOnError msbuild -p:Configuration="Release" -t:BuildAKVNetCore -p:ReferenceType=Package
-call :pauseOnError msbuild -p:Configuration="Release" -t:BuildAKVNetSt -p:ReferenceType=Package
-
-:: .NET - REFERENCE TYPE "PACKAGE"
-call :pauseOnError msbuild -p:Configuration="Release" -t:BuildTestsNetCore -p:ReferenceType=Package -p:TargetNetCoreVersion=net8.0
-call :pauseOnError dotnet test "src\Microsoft.Data.SqlClient\tests\FunctionalTests\Microsoft.Data.SqlClient.Tests.csproj" -p:Configuration="Release" -p:TestTargetOS="Windowsnetcoreapp" --no-build -v n --filter "category!=nonnetcoreapptests&category!=failing&category!=nonwindowstests" -p:Platform="AnyCPU" -p:TargetNetCoreVersion=net8.0 -p:ReferenceType=Package -l:trx;LogFileName=..\..\..\..\..\artifacts\Results\package-net8.0-functional-anycpu.xml
-call :pauseOnError dotnet test "src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTesting.Tests.csproj" -p:Configuration="Release" -p:TestTargetOS="Windowsnetcoreapp" --no-build -v n --filter "category!=nonnetcoreapptests&category!=failing&category!=nonwindowstests" -p:Platform="AnyCPU" -p:TargetNetCoreVersion=net8.0 -p:ReferenceType=Package -l:trx;LogFileName=..\..\..\..\..\artifacts\Results\package-net8.0-manual-anycpu.xml
-
-call :pauseOnError msbuild -p:Configuration="Release" -t:BuildTestsNetCore -p:ReferenceType=Package -p:Platform=x64 -p:TargetNetCoreVersion=net8.0
-call :pauseOnError dotnet test "src\Microsoft.Data.SqlClient\tests\FunctionalTests\Microsoft.Data.SqlClient.Tests.csproj" -p:Configuration="Release" -p:TestTargetOS="Windowsnetcoreapp" --no-build -v n --filter "category!=nonnetcoreapptests&category!=failing&category!=nonwindowstests" -p:Platform="x64" -p:TargetNetCoreVersion=net8.0 -p:ReferenceType=Package -l:trx;LogFileName=..\..\..\..\..\artifacts\Results\package-net8.0-functional-x64.xml
-call :pauseOnError dotnet test "src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTesting.Tests.csproj" -p:Configuration="Release" -p:TestTargetOS="Windowsnetcoreapp" --no-build -v n --filter "category!=nonnetcoreapptests&category!=failing&category!=nonwindowstests" -p:Platform="x64" -p:TargetNetCoreVersion=net8.0 -p:ReferenceType=Package -l:trx;LogFileName=..\..\..\..\..\artifacts\Results\package-net8.0-manual-x64.xml
-
-call :pauseOnError msbuild -p:Configuration="Release" -t:BuildTestsNetCore -p:ReferenceType=Package -p:Platform=Win32 -p:TargetNetCoreVersion=net8.0
-call :pauseOnError dotnet test "src\Microsoft.Data.SqlClient\tests\FunctionalTests\Microsoft.Data.SqlClient.Tests.csproj" -p:Configuration="Release" -p:TestTargetOS="Windowsnetcoreapp" --no-build -v n --filter "category!=nonnetcoreapptests&category!=failing&category!=nonwindowstests" -p:Platform="Win32" -p:TargetNetCoreVersion=net8.0 -p:ReferenceType=Package -l:trx;LogFileName=..\..\..\..\..\artifacts\Results\package-net8.0-functional-win32.xml
-call :pauseOnError dotnet test "src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTesting.Tests.csproj" -p:Configuration="Release" -p:TestTargetOS="Windowsnetcoreapp" --no-build -v n --filter "category!=nonnetcoreapptests&category!=failing&category!=nonwindowstests" -p:Platform="Win32" -p:TargetNetCoreVersion=net8.0 -p:ReferenceType=Package -l:trx;LogFileName=..\..\..\..\..\artifacts\Results\package-net8.0-manual-win32.xml
-
-:: .NET Framework - REFERENCE TYPE "PACKAGE"
-
-call :pauseOnError msbuild -p:Configuration="Release" -t:BuildTestsNetFx -p:ReferenceType=Package -p:Platform=AnyCPU -p:TargetNetFxVersion=net462
-call :pauseOnError dotnet test "src\Microsoft.Data.SqlClient\tests\FunctionalTests\Microsoft.Data.SqlClient.Tests.csproj" -p:Platform="AnyCPU" -p:Configuration="Release" -p:TestTargetOS="Windowsnetfx" --no-build -v n --filter "category!=nonnetfxtests&category!=failing&category!=nonwindowstests" -p:ReferenceType=Package -l:trx;LogFileName=..\..\..\..\..\artifacts\Results\package-net462-functional-anycpu.xml
-call :pauseOnError dotnet test "src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTesting.Tests.csproj" -p:Platform="AnyCPU" -p:Configuration="Release" -p:TestTargetOS="Windowsnetfx" --no-build -v n --filter "category!=nonnetfxtests&category!=failing&category!=nonwindowstests" -p:ReferenceType=Package -l:trx;LogFileName=..\..\..\..\..\artifacts\Results\package-net462-manual-anycpu.xml
-
-call :pauseOnError msbuild -p:Configuration="Release" -t:BuildTestsNetFx -p:ReferenceType=Package -p:Platform=AnyCPU -p:TargetNetFxVersion=net48
-call :pauseOnError dotnet test "src\Microsoft.Data.SqlClient\tests\FunctionalTests\Microsoft.Data.SqlClient.Tests.csproj" -p:Platform="AnyCPU" -p:Configuration="Release" -p:TestTargetOS="Windowsnetfx" --no-build -v n --filter "category!=nonnetfxtests&category!=failing&category!=nonwindowstests" -p:ReferenceType=Package -l:trx;LogFileName=..\..\..\..\..\artifacts\Results\package-net48-functional-anycpu.xml
-call :pauseOnError dotnet test "src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTesting.Tests.csproj" -p:Platform="AnyCPU" -p:Configuration="Release" -p:TestTargetOS="Windowsnetfx" --no-build -v n --filter "category!=nonnetfxtests&category!=failing&category!=nonwindowstests" -p:ReferenceType=Package -l:trx;LogFileName=..\..\..\..\..\artifacts\Results\package-net48-manual-anycpu.xml
-
-call :pauseOnError msbuild -p:Configuration="Release" -t:BuildTestsNetFx -p:ReferenceType=Package -p:Platform=x64 -p:TargetNetFxVersion=net462
-call :pauseOnError dotnet test "src\Microsoft.Data.SqlClient\tests\FunctionalTests\Microsoft.Data.SqlClient.Tests.csproj" -p:Platform="x64" -p:Configuration="Release" -p:TestTargetOS="Windowsnetfx" --no-build -v n --filter "category!=nonnetfxtests&category!=failing&category!=nonwindowstests" -p:ReferenceType=Package -l:trx;LogFileName=..\..\..\..\..\artifacts\Results\package-net462-functional-x64.xml
-call :pauseOnError dotnet test "src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTesting.Tests.csproj" -p:Platform="x64" -p:Configuration="Release" -p:TestTargetOS="Windowsnetfx" --no-build -v n --filter "category!=nonnetfxtests&category!=failing&category!=nonwindowstests" -p:ReferenceType=Package -l:trx;LogFileName=..\..\..\..\..\artifacts\Results\package-net462-manual-x64.xml
-
-call :pauseOnError msbuild -p:Configuration="Release" -t:BuildTestsNetFx -p:TargetNetFxVersion=net48 -p:Platform=x64 -p:ReferenceType=Package
-call :pauseOnError dotnet test "src\Microsoft.Data.SqlClient\tests\FunctionalTests\Microsoft.Data.SqlClient.Tests.csproj" -p:Platform="x64" -p:Configuration="Release" -p:TestTargetOS="Windowsnetfx" -p:TargetNetFxVersion=net48 --no-build -v n --filter "category!=nonnetfxtests&category!=failing&category!=nonwindowstests" -p:ReferenceType=Package -l:trx;LogFileName=..\..\..\..\..\artifacts\Results\package-net48-functional-x64.xml
-call :pauseOnError dotnet test "src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTesting.Tests.csproj" -p:Platform="x64" -p:Configuration="Release" -p:TestTargetOS="Windowsnetfx" -p:TargetNetFxVersion=net48 --no-build -v n --filter "category!=nonnetfxtests&category!=failing&category!=nonwindowstests" -p:ReferenceType=Package -l:trx;LogFileName=..\..\..\..\..\artifacts\Results\package-net48-manual-x64.xml
-
-call :pauseOnError msbuild -p:Configuration="Release" -t:BuildTestsNetFx -p:ReferenceType=Package -p:Platform=Win32 -p:TargetNetFxVersion=net462
-call :pauseOnError dotnet test "src\Microsoft.Data.SqlClient\tests\FunctionalTests\Microsoft.Data.SqlClient.Tests.csproj" -p:Platform="Win32" -p:Configuration="Release" -p:TestTargetOS="Windowsnetfx" --no-build -v n --filter "category!=nonnetfxtests&category!=failing&category!=nonwindowstests" -p:ReferenceType=Package -l:trx;LogFileName=..\..\..\..\..\artifacts\Results\package-net462-functional-win32.xml
-call :pauseOnError dotnet test "src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTesting.Tests.csproj" -p:Platform="Win32" -p:Configuration="Release" -p:TestTargetOS="Windowsnetfx" --no-build -v n --filter "category!=nonnetfxtests&category!=failing&category!=nonwindowstests" -p:ReferenceType=Package -l:trx;LogFileName=..\..\..\..\..\artifacts\Results\package-net462-manual-win32.xml
-
-call :pauseOnError msbuild -p:Configuration="Release" -t:BuildTestsNetFx -p:TargetNetFxVersion=net48 -p:Platform=Win32 -p:ReferenceType=Package
-call :pauseOnError dotnet test "src\Microsoft.Data.SqlClient\tests\FunctionalTests\Microsoft.Data.SqlClient.Tests.csproj" -p:Platform="Win32" -p:Configuration="Release" -p:TestTargetOS="Windowsnetfx" -p:TargetNetFxVersion=net48 --no-build -v n --filter "category!=nonnetfxtests&category!=failing&category!=nonwindowstests" -p:ReferenceType=Package -l:trx;LogFileName=..\..\..\..\..\artifacts\Results\package-net48-functional-Win32.xml
-call :pauseOnError dotnet test "src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTesting.Tests.csproj" -p:Platform="Win32" -p:Configuration="Release" -p:TestTargetOS="Windowsnetfx" -p:TargetNetFxVersion=net48 --no-build -v n --filter "category!=nonnetfxtests&category!=failing&category!=nonwindowstests" -p:ReferenceType=Package -l:trx;LogFileName=..\..\..\..\..\artifacts\Results\package-net48-manual-Win32.xml
-
-goto :eof
-
-:pauseOnError
-%*
-if ERRORLEVEL 1 pause
-goto :eof
diff --git a/RunProjectReferenceTests.cmd b/RunProjectReferenceTests.cmd
deleted file mode 100644
index 2e37d0b71..000000000
--- a/RunProjectReferenceTests.cmd
+++ /dev/null
@@ -1,54 +0,0 @@
-@echo off
-
-:: Default target frameworks
-set netfxVersion=net462
-set netcoreVersion=net8.0
-
-:: Accept two parameters for .NET Framework and .NET versions.
-:: Examples:
-:: - uses net48 and net8.0:
-:: > RunProjectReferenceTests.cmd net48 net8.0
-:: - uses default target frameworks:
-:: > RunProjectReferenceTests.cmd
-:: - uses net48 and default target frameworks for netcore:
-:: > RunProjectReferenceTests.cmd net48
-
-if not "%~1" == "" set netfxVersion=%1
-if not "%~2" == "" set netcoreVersion=%2
-
-echo .NET Framework = %netfxVersion%
-echo .NET Core = %netcoreVersion%
-
-call :pauseOnError msbuild -t:Clean
-:: .NET FRAMEWORK - REFERENCE TYPE "PROJECT"
-:: Only Builds AnyCPU for project reference!
-
-:: Based on `dotnet test` documentation, the `Platform` property has no effect on choosing the underlying architecture for the test execution environment.
-:: You need to install and run the `dotnet` command for a specific architecture (x64, x86, Arm64).
-
-echo Building .NET Framework %netfxVersion% Tests ...
-call :pauseOnError msbuild -p:Configuration="Release"
-call :pauseOnError msbuild -p:Configuration="Release" -t:BuildAKVNetFx
-call :pauseOnError msbuild -p:Configuration="Release" -t:BuildTestsNetFx -p:TargetNetFxVersion=%netfxVersion%
-
-echo Running .NET Framework %netfxVersion% Tests ...
-call :pauseOnError dotnet test "src\Microsoft.Data.SqlClient\tests\FunctionalTests\Microsoft.Data.SqlClient.Tests.csproj" -p:Configuration="Release" -p:TestTargetOS="Windowsnetfx" -p:TargetNetFxVersion=%netfxVersion% --no-build -v n --filter "category!=nonnetfxtests&category!=failing&category!=nonwindowstests" -l:"trx;LogFileName=..\..\..\..\..\artifacts\Results\project-%netfxVersion%-functional-anycpu.xml"
-call :pauseOnError dotnet test "src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTesting.Tests.csproj" -p:Configuration="Release" -p:TestTargetOS="Windowsnetfx" -p:TargetNetFxVersion=%netfxVersion% --no-build -v n --filter "category!=nonnetfxtests&category!=failing&category!=nonwindowstests" -l:"trx;LogFileName=..\..\..\..\..\artifacts\Results\project-%netfxVersion%-manual-anycpu.xml"
-
-echo Building .NET %netcoreVersion% Tests ...
-call pause
-call :pauseOnError msbuild -t:Clean
-call :pauseOnError msbuild -p:Configuration="Release"
-call :pauseOnError msbuild -p:Configuration="Release" -t:BuildAKVNetCoreAllOS
-call :pauseOnError msbuild -p:Configuration="Release" -t:BuildTestsNetCore -p:TargetNetCoreVersion=%netcoreVersion%
-
-echo Running .NET %netcoreVersion% Tests ...
-call :pauseOnError dotnet test "src\Microsoft.Data.SqlClient\tests\FunctionalTests\Microsoft.Data.SqlClient.Tests.csproj" -p:Configuration="Release" -p:TestTargetOS="Windowsnetcoreapp" -p:TargetNetCoreVersion=%netcoreVersion% --no-build -v n --filter "category!=nonnetcoreapptests&category!=failing&category!=nonwindowstests" -l:"trx;LogFileName=..\..\..\..\..\artifacts\Results\project-%netcoreVersion%-functional-anycpu.xml"
-call :pauseOnError dotnet test "src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTesting.Tests.csproj" -p:Configuration="Release" -p:TestTargetOS="Windowsnetcoreapp" -p:TargetNetCoreVersion=%netcoreVersion% --no-build -v n --filter "category!=nonnetcoreapptests&category!=failing&category!=nonwindowstests" -l:"trx;LogFileName=..\..\..\..\..\artifacts\Results\project-%netcoreVersion%-manual-anycpu.xml"
-
-goto :eof
-
-:pauseOnError
-%*
-if ERRORLEVEL 1 pause
-goto :eof
diff --git a/RunTests.sh b/RunTests.sh
deleted file mode 100644
index ed3f22a9a..000000000
--- a/RunTests.sh
+++ /dev/null
@@ -1,8 +0,0 @@
-dotnet msbuild -p:Configuration="Release" -t:Clean,BuildAll -p:GenerateDocumentationFile=false
-echo Building Add-Ons
-dotnet msbuild -p:Configuration="Release" -t:BuildAKVNetCore -p:OSGroup=Unix -p:Platform=AnyCPU
-echo Building tests
-dotnet msbuild -p:Configuration="Release" -t:BuildTestsNetCore -p:OSGroup=Unix -p:Platform=AnyCPU
-echo Running SqlClient test suite
-dotnet test "src/Microsoft.Data.SqlClient/tests/FunctionalTests/Microsoft.Data.SqlClient.Tests.csproj" -p:Platform="AnyCPU" -p:Configuration="Release" -p:TestTargetOS="Unixnetcoreapp" --no-build -v n --filter "category!=nonnetcoreapptests&category!=failing&category!=nonlinuxtests&category!=nonuaptests"
-dotnet test "src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj" -p:Platform="AnyCPU" -p:Configuration="Release" -p:TestTargetOS="Unixnetcoreapp" --no-build -v n --filter "category!=nonnetcoreapptests&category!=failing&category!=nonlinuxtests&category!=nonuaptests"
diff --git a/build.proj b/build.proj
index 90f5f0fc3..0443bbcf4 100644
--- a/build.proj
+++ b/build.proj
@@ -26,7 +26,7 @@
netcoreapp
$(TF)
$(TF)
- true
+ true
Configuration=$(Configuration);AssemblyVersion=$(SqlServerAssemblyVersion);AssemblyFileVersion=$(SqlServerAssemblyFileVersion);Version=$(SqlServerPackageVersion);
Configuration=$(Configuration);AssemblyFileVersion=$(AssemblyFileVersion);TargetsWindows=$(TargetsWindows);TargetsUnix=$(TargetsUnix);
BuildProjectReferences=false;$(ProjectProperties);BuildForRelease=false;TargetNetCoreVersion=$(TargetNetCoreVersion);TargetNetFxVersion=$(TargetNetFxVersion)
@@ -90,7 +90,6 @@
-
@@ -118,7 +117,7 @@
- $(DotNetCmd) dotnet build -c Release -p:ReferenceType=$(ReferenceType)
+ dotnet build -c Release -p:ReferenceType=$(ReferenceType)
diff --git a/buildAddons.cmd b/buildAddons.cmd
deleted file mode 100644
index 70d1797dd..000000000
--- a/buildAddons.cmd
+++ /dev/null
@@ -1,12 +0,0 @@
-call :pauseOnError msbuild -p:configuration=Release -t:clean
-call :pauseOnError msbuild -p:configuration=Release -t:BuildAllConfigurations
-call :pauseOnError msbuild -p:configuration=Release -t:BuildAKVNetFx
-call :pauseOnError msbuild -p:configuration=Release -t:BuildAKVNetCoreAllOS
-call :pauseOnError msbuild -p:configuration=Release -t:GenerateAKVProviderNugetPackage
-
-goto :eof
-
-:pauseOnError
-%*
-if ERRORLEVEL 1 pause
-goto :eof
diff --git a/override.ps1 b/override.ps1
deleted file mode 100644
index 4c1a37983..000000000
--- a/override.ps1
+++ /dev/null
@@ -1,43 +0,0 @@
-#Purpose: Updates SNI Version
-Write-Host "SNI Version to test = 123"
-
-##Get the shared SNI Version from the downloaded artifact
-#$SharedSNIVersion = Get-Content -path "$(Pipeline.Workspace)/SharedSNIVersion.txt"
-
-#Get the SNI Version to test from the user entered version.
-$SharedSNIVersion = "123"
-
-# define file to update
-$PropsPath = 'C:\Users\mdaigle\SqlClient\tools\props\Versions.props'
-type $PropsPath
-
-# new version number to update to
-##Write-Host "SNI Version to test = $(SNIValidationVersion)"
-Write-Host "SNI Version to test = $SharedSNIVersion"
-
-
-# define an xml object
-$xml = New-Object XML
-
-# load content of xml from file defined above
-$xml.Load($PropsPath)
-
-# define namespace used to read a node
-$nsm = New-Object Xml.XmlNamespaceManager($xml.NameTable)
-$nsm.AddNamespace('ns', $xml.DocumentElement.NamespaceURI)
-$netFxSniVersion = $xml.SelectSingleNode('//ns:MicrosoftDataSqlClientSniVersion', $nsm)
-
-Write-Host "Node NetFx SNI Version = $($netFxSniVersion.InnerText)"
-
-# update the node inner text
-$netFxSniVersion.InnerText = "$SharedSNIVersion"
-
-$netCoreSniVersion = $xml.SelectSingleNode('//ns:MicrosoftDataSqlClientSNIRuntimeVersion', $nsm)
-
-# update the node inner text
-$netCoreSniVersion.InnerText = "$SharedSNIVersion"
-
-# save the xml file
-$xml.Save($PropsPath)
-
-type $PropsPath
diff --git a/tools/GenAPI/Directory.Build.Props b/tools/GenAPI/Directory.Build.props
similarity index 100%
rename from tools/GenAPI/Directory.Build.Props
rename to tools/GenAPI/Directory.Build.props
diff --git a/tools/targets/NotSupported.targets b/tools/targets/NotSupported.targets
index 890c4ae04..124d86f87 100644
--- a/tools/targets/NotSupported.targets
+++ b/tools/targets/NotSupported.targets
@@ -42,7 +42,7 @@
$(GenAPIArgs) -o:"$(NotSupportedSourceFile)"
$(GenAPIArgs) -t:"$(GeneratePlatformNotSupportedAssemblyMessage)"
$(GenAPIArgs) -global
- "$(DotNetCmd) $(ToolsArtifactsDir)$(TargetFramework)\Microsoft.DotNet.GenAPI.dll"
+ "$(DotnetPath)dotnet" "$(ToolsArtifactsDir)net8.0/Microsoft.DotNet.GenAPI.dll"
"$(ToolsArtifactsDir)net472\Microsoft.DotNet.GenAPI.exe"