 Update sinon to v8.1.1 and fix abort tracking in mediaRequestsAborted (#724)
* Update sinon to v8.1.1 and fix abort tracking in mediaRequestsAborted
* Add check to media-segment-request for empty responseText when handling partial data
This was not needed in the past, as the responseText property of a sinon response was
anually set by VHS' test helpers. However, sinon now clears out the responseText property
on a response, the mime type override trick doesn't work like it would in a browser. The
additional check to the code should prove harmless, and acts as a guard against browsers
which don't implement the mime type override trick in the same way.
* Add an abortFn callback to media-segment-request to fix abort tracking in
mediaRequestsAborted
In the previously used version of sinon (v1.10.3), aborts of requests triggered the XHR
callback. In the XHR standard however, this does not happen. Later versions of sinon fixed
this issue. VHS' use of the old sinon lead to tests relying on broken behavior to verify
abort tracking in mediaRequestsAborted.
To properly use mediaRequestsAborted, aborts are tracked on loadend, part of XHR's
[request error steps](https://xhr.spec.whatwg.org/#request-error-steps), and called back
via the abortFn to increment mediaRequestsAborted
* Skip id3 with partial data handling tests until they no longer rely on segments being
fully requested
A couple of tests checking for id3 frames surfacing from partial data handling were found
to rely on the segment finishing its request before the data was surfaced. These tests are
skipped until a fix can be made such that they rely only on partial data.
* No longer override sinon's abort behavior for tests
* No longer work around sinon's response types in standardXHRResponse
With a newer sinon version, a few workarounds needed in test-helpers are no longer needed.
* Skip partial data caption tests until they no longer rely on full segment responses
6 years ago |
|
{ "name": "@videojs/http-streaming", "version": "2.0.0", "description": "Play back HLS and DASH with Video.js, even where it's not natively supported", "main": "dist/videojs-http-streaming.cjs.js", "module": "dist/videojs-http-streaming.es.js", "repository": { "type": "git", "url": "git@github.com:videojs/http-streaming.git" }, "scripts": { "prenetlify": "npm run build", "netlify": "node scripts/netlify.js", "build-test": "cross-env-shell TEST_BUNDLE_ONLY=1 'npm run build'", "build-prod": "cross-env-shell NO_TEST_BUNDLE=1 'npm run build'", "build": "npm-run-all -s clean -p build:*", "build:js": "rollup -c scripts/rollup.config.js", "docs": "npm-run-all docs:*", "docs:api": "jsdoc src -g plugins/markdown -r -d docs/api", "docs:toc": "doctoc --notitle README.md", "docs:images": "node ./scripts/create-docs-images.js", "clean": "shx rm -rf ./dist ./test/dist && shx mkdir -p ./dist ./test/dist", "lint": "vjsstandard", "prepublishOnly": "npm-run-all build-prod && vjsverify --verbose", "start": "npm-run-all -p server watch", "server": "karma start scripts/karma.conf.js --singleRun=false --auto-watch", "test": "npm-run-all lint build-test && karma start scripts/karma.conf.js", "preversion": "npm test", "version": "is-prerelease || npm run update-changelog && git add CHANGELOG.md", "update-changelog": "conventional-changelog -p videojs -i CHANGELOG.md -s", "watch": "npm-run-all -p watch:*", "watch:js": "npm run build:js -- -w" }, "keywords": [ "videojs", "videojs-plugin" ], "author": "Brightcove, Inc", "license": "Apache-2.0", "vjsstandard": { "ignore": [ "dist", "docs", "deploy", "test/dist", "utils", "src/*.worker.js" ] }, "files": [ "CONTRIBUTING.md", "dist/", "docs/", "index.html", "scripts/", "src/" ], "dependencies": { "@babel/runtime": "^7.5.5", "@videojs/vhs-utils": "^2.2.0", "aes-decrypter": "3.0.1", "global": "^4.3.2", "m3u8-parser": "4.4.2", "mpd-parser": "0.10.1", "mux.js": "5.6.6", "video.js": "^6 || ^7" }, "devDependencies": { "@gkatsev/rollup-plugin-bundle-worker": "^1.0.2", "@videojs/generator-helpers": "~1.2.0", "d3": "^3.4.8", "es5-shim": "^4.5.13", "es6-shim": "^0.35.5", "jsdoc": "BrandonOCasey/jsdoc#feat/plugin-from-cli", "karma": "^4.0.0", "lodash": "^4.17.4", "lodash-compat": "^3.10.0", "nomnoml": "^0.3.0", "rollup": "^1.19.4", "shelljs": "^0.8.2", "sinon": "^8.1.1", "url-toolkit": "^2.1.3", "videojs-contrib-eme": "^3.2.0", "videojs-contrib-quality-levels": "^2.0.4", "videojs-generate-karma-config": "~5.3.1", "videojs-generate-rollup-config": "~5.0.1", "videojs-generator-verify": "~2.0.0", "videojs-http-source-selector": "^1.1.6", "videojs-standard": "^8.0.3" }, "generator-videojs-plugin": { "version": "7.6.3" }, "browserslist": [ "defaults", "ie 11" ], "engines": { "node": ">=8", "npm": ">=5" }, "husky": { "hooks": { "pre-commit": "lint-staged" } }, "lint-staged": { "*.js": [ "vjsstandard --fix", "git add" ], "README.md": [ "doctoc --notitle", "git add" ] }}
|
