Browse Source

chore: disallow console statement (#9986)

pull/9988/head
三咲智子 Kevin Deng 2 years ago
committed by GitHub
parent
commit
fda51925f4
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 4
      .eslintrc.cjs
  2. 1
      packages/runtime-core/src/components/Suspense.ts
  3. 1
      packages/server-renderer/src/renderToStream.ts

4
.eslintrc.cjs

@ -19,6 +19,7 @@ module.exports = {
plugins: ['jest', 'import', '@typescript-eslint'],
rules: {
'no-debugger': 'error',
'no-console': ['error', { allow: ['warn', 'error', 'info'] }],
// most of the codebase are expected to be env agnostic
'no-restricted-globals': ['error', ...DOMGlobals, ...NodeGlobals],
@ -58,6 +59,7 @@ module.exports = {
{
files: ['**/__tests__/**', 'packages/dts-test/**'],
rules: {
'no-console': 'off',
'no-restricted-globals': 'off',
'no-restricted-syntax': 'off',
'jest/no-disabled-tests': 'error',
@ -92,6 +94,7 @@ module.exports = {
rules: {
'no-restricted-globals': ['error', ...NodeGlobals],
'no-restricted-syntax': ['error', banConstEnum],
'no-console': 'off',
},
},
// JavaScript files
@ -113,6 +116,7 @@ module.exports = {
rules: {
'no-restricted-globals': 'off',
'no-restricted-syntax': ['error', banConstEnum],
'no-console': 'off',
},
},
// Import nodejs modules in compiler-sfc

1
packages/runtime-core/src/components/Suspense.ts

@ -444,6 +444,7 @@ function createSuspenseBoundary(
if (__DEV__ && !__TEST__ && !hasWarned) {
hasWarned = true
// @ts-expect-error `console.info` cannot be null error
// eslint-disable-next-line no-console
console[console.info ? 'info' : 'log'](
`<Suspense> is an experimental feature and its API will likely change.`,
)

1
packages/server-renderer/src/renderToStream.ts

@ -206,6 +206,7 @@ export function pipeToWebWritable(
},
destroy(err) {
// TODO better error handling?
// eslint-disable-next-line no-console
console.log(err)
writer.close()
},

Loading…
Cancel
Save